Skip to content

release-winget.yml: fix submission pwsh script #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

mjcheetham
Copy link
Member

During a refactoring I accidentally omitted the $manifestPath variable that is required to determine the $manifestDirectory for the submission command to WinGet. Since the $manifestDirectory is just a constant, let's update the submission command.

@dscho
Copy link
Member

dscho commented Apr 29, 2025

Strangely, I needed a couple of updates, until the deployment finally worked: microsoft/winget-pkgs#251831. I will force-push the PR branch as soon as CI has finished (so that the config job can realize that nothing needs to be done).

Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjcheetham mjcheetham requested a review from dscho April 30, 2025 07:33
dscho
dscho previously approved these changes Apr 30, 2025
@dscho
Copy link
Member

dscho commented Apr 30, 2025

image

What the hay? This is starting to get ridiculous. I know that a team of two is very small, but how is this supposed to work for us? The ruleset prevents all of us two team members from merging. This is not going to work.

During a refactoring I accidentally omitted the `$manifestPath`
variable that is required to determine the `$manifestDirectory`
for the submission command to WinGet. Since the directory is
just a constant, let's update the submission command.

Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
Signed-off-by: Johannes Schindelin <johasc@microsoft.com>
@dscho dscho merged commit ba7e40a into microsoft:vfs-2.49.0 Apr 30, 2025
32 checks passed
@dscho
Copy link
Member

dscho commented Apr 30, 2025

image

What the hay? This is starting to get ridiculous. I know that a team of two is very small, but how is this supposed to work for us? The ruleset prevents all of us two team members from merging. This is not going to work.

So apparently it was not merely the last push, but force-pushing to a tree-same commit does not lift that restriction. Surprising, and not what the message said.

@mjcheetham mjcheetham deleted the fix-winget branch April 30, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants